Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS webView full-screen mode #791

Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #785

@kelson42
Copy link
Contributor

kelson42 commented Jun 6, 2024

@BPerlakiH Thanks for the PR. I have no macOS 14 to test, but modulo #772, ZIM with webm videos shoukd work perfectly now. You confirm?

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Jun 6, 2024

@kelson42 yes, apart from #772 webm works great on macOS.

Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 35e5160 into main Jun 7, 2024
4 checks passed
@kelson42 kelson42 deleted the 785-on-macos-the-video-is-not-taking-up-the-full-screen branch June 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On macOS the video is not "taking up" the full screen
2 participants